Skip to content

Conversation

riberk
Copy link
Contributor

@riberk riberk commented Oct 19, 2025

This PR updates MSRV to 1.82 (min allowed) because of the indexmap crate update. This crate is a dependency of a proc-macro-crate which is a dependency of rs-test.

MSRV before the change is breaking like in this CI failure

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update the version string in Cargo.toml:

rust-version = "1.77"

@riberk
Copy link
Contributor Author

riberk commented Oct 19, 2025

@JohnTitor Thanks for the review!

You should also update the version string in Cargo.toml:

Done, and have updated README.md either

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@JohnTitor JohnTitor merged commit a256610 into notify-rs:main Oct 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants