Fix: Enable Windows to determine File or Folder in events #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boenrobot
commented
Oct 21, 2025
| }; | ||
| } | ||
| match cur_entry.Action { | ||
| FILE_ACTION_RENAMED_OLD_NAME => { |
There was a problem hiding this comment.
I also rolled the FILE_ACTION_RENAMED_OLD_NAME into the match... Because I can't see any reason it shouldn't be in it already. Was there a good reason that I'm unaware of? If so, I can revert this part.
…ich the FileAttributes can tell if a file or folder is being created/modified/deleted. This raises the minimum required Windows version to Windows 10, as this is where ReadDirectoryChangesExW was introduced.
boenrobot
force-pushed
the
winTheTypeOfEvent
branch
from
54df206 to
572dfbf
Compare
|
As per @JohnTitor in #261, I made it backwards compatible for older versions of Windows too, with a one time runtime check (the results of which are passed around). Did so by effectively duplicating handle_event (into handle_extended_event). I'm sure there's portions of the code that can be made more DRY, but then again, it might be less error prone to have to keep up to date two copies, and maybe eventually drop the older one. |
…le (Windows versions earlier than 10). Checked dynamically once at server creation and passed along to the ReadData.
boenrobot
force-pushed
the
winTheTypeOfEvent
branch
from
ad4f803 to
bdba4e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ReadDirectoryChangesW with ReadDirectoryChangesExW, out of which the FileAttributes can tell if a file or folder is being created/modified/deleted.
This raises the minimum required Windows version to Windows 10, as this is where ReadDirectoryChangesExW was introduced.
Fixes #261