feat: apply April research results#2353
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request removes dark theme CSS variable definitions and theme-dependent styling from the main stylesheet, transitioning to a light-only theme approach. The CSS simplification comments out dark theme selectors and removes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
app/assets/main.css (1)
8-54: Consider removing commented-out code rather than leaving it in place.Commenting out ~80 lines of dark theme CSS creates technical debt and reduces readability. If dark theme is being permanently removed based on research findings, this dead code should be deleted. Version control preserves history if restoration is ever needed.
app/pages/settings.vue (1)
5-5: Remove commented-out code for consistency.Similar to the CSS file, the commented-out
useColorMode()call and theme selector block should be deleted if dark theme is permanently removed. Leaving commented code in production creates confusion about whether this is temporary or permanent.Additionally, note that other composables (e.g.
useAccentColor()inapp/composables/useSettings.ts) still invokeuseColorMode(), so the colour mode machinery remains active even though the UI is hidden.Also applies to: 69-85
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b07638e3-7a61-4086-a885-cb0a58d11571
📒 Files selected for processing (4)
app/assets/main.cssapp/pages/index.vueapp/pages/settings.vuevercel.json
serhalp
changed the title
2 participants
🧭 Context
We've completed one of the longest projects and it seems that since the results were almost absolute, we can merge and release it right away.
We’ve completed our user experience research and carefully reviewed the results. To deliver the best possible experience, we’ve decided to remove the dark theme.
We’re committed to making decisions based on what works best for our users and are glad we took the time to validate this through research.
Thank you for participating 🤍
This is the first version right after results, so there is no perfect code yet. In the next version, we plan to update the
nuxtjs/color-modemodule and distribute the results to all nuxt projects.Long story short
We’ve just wrapped up one of the longest research efforts we’ve run so far, looking closely at how people actually use the product over time.
One of the topics we explored was the dark theme. It’s something many people expect by default, so we wanted to understand how it holds up in real usage — not just in theory.
What we saw
The results were… pretty one-sided:
93% of sessions happen during daytime hours
88% of users use the product in well-lit environments
95% said content felt easy to read when they opened npmx in light mode
76% completed tasks faster without dark themed workspaces
97% supported removing it after trying both options
At the same time:
91% said consistency across the interface matters more than having multiple themes
A noticeable number of users who initially preferred dark mode changed their mind after using both for a while
What users said
“I usually prefer dark mode, but here I didn’t feel like I needed it.” — User A
“Light mode just feels clearer. I don’t have to think about it.” — User B
“Dark theme looks good, but I slow down a bit when I actually use it.” — User C
“If I had to choose, I’d pick whatever makes things common” — User D
There was a recurring pattern:
dark mode was often described as nice, but light mode as absolute.
A small but interesting detail
Even among people who said they prefer dark interfaces in general, many didn’t actively switch to it here.
Not for a big reason, just small things:
contrast, light speed.
The decision
Given how consistent the signals were, we decided to remove the dark theme and focus on a single, well-optimized light experience.
Not because dark mode is bad, and not as a universal statement — just because, in this case, it didn’t seem to add much value compared to the cost of maintaining it.
Why we’re sharing this
Because it’s a good reminder for us:
what people expect, what they say, and what actually works — aren’t always the same thing.
And sometimes the result isn’t dramatic.
It’s just… quieter, simpler, and a bit more obvious in hindsight. Especially when April rolls around.