-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add aclk_mck testcase on i2s_mclk for nRF7120 #26126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also rename hfxo32m to pclk32m. Signed-off-by: Dhanoo Surasarang <[email protected]>
Previously failing due to incorrect pclk frequency on TDM. Signed-off-by: Dhanoo Surasarang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new test case for the nRF7120 platform and corrects clock naming inconsistencies in the device tree. The changes enable a previously failing test case by ensuring TDM uses the correct 32MHz clock source.
- Adds
aclk_mcktest case for nRF7120 platform that was previously failing - Renames
hfxo32mclock topclk32mfor consistency and accuracy - Updates all clock references to use the renamed
pclk32m
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/drivers/i2s/i2s_mclk/testcase.yaml | Adds new test case configuration for nRF7120 platform with gpio_loopback fixture |
| dts/common/nordic/nrf7120_enga.dtsi | Renames hfxo32m to pclk32m and updates all references to the renamed clock |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: b0086fa2debee33b5bbe0f1db08ef39051ef43c9 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 43683a87ea Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Previously failing due to incorrect pclk frequency on TDM which is now using pclk32m. The clock hfxo32m is also renamed to pclk32m.