-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): use @nx/maven to build @nx/maven #33412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 4d25475
☁️ Nx Cloud last updated this comment at |
c1afe9d to
e5817c2
Compare
2811980 to
4085a8e
Compare
pnpm-lock.yaml
Outdated
| '@nx/maven': | ||
| specifier: 22.1.0-rc.2 | ||
| version: 22.1.0-rc.2([email protected](@swc-node/[email protected](@swc/[email protected](@swc/[email protected]))(@swc/[email protected])([email protected]))(@swc/[email protected](@swc/[email protected]))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch detected: package.json specifies @nx/maven: 22.1.0-rc.3 but pnpm-lock.yaml has locked version 22.1.0-rc.2. This mismatch will cause the wrong version to be installed.
# Fix by running:
pnpm install
# This will update the lockfile to match package.jsonThe lockfile must be regenerated to match the version specified in package.json to ensure consistent installations across environments.
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
4085a8e to
2e912b4
Compare
.github/workflows/ci.yml
Outdated
| - name: Show project graph | ||
| run: npx nx show project nx-maven-plugin | jq .targets.test | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure once debugging is done I'll remove it 👍
030a984 to
bc83756
Compare
8e08dae to
2db5d8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud is proposing a fix for your failed CI:
These changes fix the Maven plugin resolution error by enabling installation of the parent POM (dev.nx:nx-parent:pom:0.0.10) to the local Maven repository. When the e2e tests initialize @nx/maven, Maven needs to resolve the parent POM that the maven-plugin references, and with maven.install.skip=false, the parent POM will now be available in the local repository instead of failing with "artifact not found" errors.
diff --git a/pom.xml b/pom.xml
index 60d8dd088b..852bf6c8ea 100644
--- a/pom.xml
+++ b/pom.xml
@@ -41,7 +41,7 @@
<properties>
<!-- Skip deploying parent POM -->
<maven.deploy.skip>true</maven.deploy.skip>
- <maven.install.skip>true</maven.install.skip>
+ <maven.install.skip>false</maven.install.skip>
<maven.gpg.skip>true</maven.gpg.skip>
<!-- Build Properties -->
Or Apply changes locally with:
npx nx-cloud apply-locally 5cj7-BKeu
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
4d25475 to
a97e635
Compare
Current Behavior
there is an
installtarget calling./mvnwdirectlyExpected Behavior
we use the
@nx/mavenplugin for generating maven targets