Skip to content

fix(core): make nx version lookup bundle-safe#35430

Merged
FrozenPandaz merged 1 commit into
nrwl:masterfrom
MaxKless:fix/bundle-safe-nx-version
Apr 24, 2026
Merged

fix(core): make nx version lookup bundle-safe#35430
FrozenPandaz merged 1 commit into
nrwl:masterfrom
MaxKless:fix/bundle-safe-nx-version

Conversation

@MaxKless
Copy link
Copy Markdown
Contributor

Current Behavior

Nx reads its own version through a package.json path derived from __filename. When Nx internals are bundled into another tool, that relative path can point outside the original package layout.

Expected Behavior

Nx resolves its version through the exported nx/package.json self-reference, so bundlers can resolve it statically and the runtime no longer depends on the source/dist file layout.

Related Issue(s)

N/A

@MaxKless MaxKless requested a review from a team as a code owner April 24, 2026 12:38
@MaxKless MaxKless requested a review from leosvelperez April 24, 2026 12:38
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for nx-docs canceled.

Name Link
🔨 Latest commit f61c325
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69eb6459d5c40f0008d5988c

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for nx-dev canceled.

Name Link
🔨 Latest commit f61c325
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69eb645912870c0008f04a8d

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 24, 2026

View your CI Pipeline Execution ↗ for commit f61c325

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 49m 27s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 18s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 24s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-24 13:31:46 UTC

@FrozenPandaz FrozenPandaz merged commit e0c530a into nrwl:master Apr 24, 2026
22 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants