Skip to content

services/object: use SearchV2 for search objects #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

services/object: use SearchV2 for search objects #3312

merged 1 commit into from
May 13, 2025

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Apr 18, 2025

Closes #3143.

I hope I understood correctly what exactly needs to be changed.

@End-rey End-rey self-assigned this Apr 18, 2025
roman-khimov
roman-khimov reviewed Apr 23, 2025
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still does too much to me. This affects Search RPC operation, while the intention was to convert internal SN users to proper SearchV2. We'll need to do this anyway once we're to drop the old Search, so better isolate SN calls (not related to Search processing) and deal only with them.

@End-rey End-rey force-pushed the 3143-use-searchv2-for-internal-sn-needs branch from 6f5d97c to 79eb637 Compare April 25, 2025 12:13
@End-rey End-rey marked this pull request as draft April 25, 2025 12:14
@End-rey
Copy link
Contributor Author

End-rey commented Apr 25, 2025

@roman-khimov Is that what you need? Am I in the right direction?

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 12.00000% with 88 lines in your changes missing coverage. Please review.

Project coverage is 21.15%. Comparing base (fc1f21f) to head (1ac26db).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/object/server.go 5.88% 64 Missing ⚠️
cmd/neofs-node/object.go 0.00% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3312      +/-   ##
==========================================
- Coverage   21.19%   21.15%   -0.04%     
==========================================
  Files         719      719              
  Lines       53190    53189       -1     
==========================================
- Hits        11272    11253      -19     
- Misses      41126    41143      +17     
- Partials      792      793       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roman-khimov
roman-khimov reviewed Apr 25, 2025
View reviewed changes
@End-rey End-rey force-pushed the 3143-use-searchv2-for-internal-sn-needs branch from 79eb637 to 2379117 Compare May 7, 2025 15:28
@End-rey End-rey marked this pull request as ready for review May 7, 2025 15:29
@End-rey End-rey requested a review from roman-khimov May 7, 2025 15:29
roman-khimov
roman-khimov reviewed May 7, 2025
View reviewed changes
cmd/neofs-node/object.go
@@ -314,6 +317,7 @@ func initObjectService(c *cfg) {
keys: keyStorage,
}
server := objectService.New(objSvc, mNumber, fsChain, storage, c.metaService, c.shared.basics.key.PrivateKey, c.metricsCollector, aclChecker, aclSvc, coreConstructor)
os.server = server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems racy, os is already given to the tombstone.NewVerifier(). Not sure there are any threads involved though, maybe not a problem.

@End-rey End-rey force-pushed the 3143-use-searchv2-for-internal-sn-needs branch 2 times, most recently from 577d37c to c0b999e Compare May 12, 2025 10:45
@End-rey End-rey requested a review from roman-khimov May 12, 2025 15:04
roman-khimov
roman-khimov reviewed May 12, 2025
View reviewed changes
@End-rey End-rey force-pushed the 3143-use-searchv2-for-internal-sn-needs branch from c0b999e to 09d1b98 Compare May 12, 2025 16:53
roman-khimov
roman-khimov approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog, please.

@End-rey End-rey force-pushed the 3143-use-searchv2-for-internal-sn-needs branch from 09d1b98 to 1ac26db Compare May 13, 2025 08:40
@roman-khimov roman-khimov merged commit 490e7b1 into master May 13, 2025
16 of 20 checks passed
@roman-khimov roman-khimov deleted the 3143-use-searchv2-for-internal-sn-needs branch May 13, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

Assignees

@End-rey End-rey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use SearchV2 for internal SN needs
3 participants
@End-rey @roman-khimov @cthulhu-rider