node/grpc: Return to passthrough address resolution scheme #3334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3334 +/- ##
==========================================
- Coverage 21.17% 21.17% -0.01%
==========================================
Files 718 718
Lines 53119 53122 +3
==========================================
Hits 11246 11246
- Misses 41079 41083 +4
+ Partials 794 793 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
deadlines
branch
8 times, most recently
from
c9d57e6 to
d25de6b
Compare
cthulhu-rider
force-pushed
the
deadlines
branch
15 times, most recently
from
55d1660 to
a2426f9
Compare
cthulhu-rider
changed the title
979811e switched SN-to-SN gRPC dial approach from 'passthrough' resolution scheme (used by `grpc.Dial*` functions) to the `dns` one (`grpc.NewClient`). This was not intentional, but it did cause visible changes in behavior. The DNS resolver began to introduce time costs into processing. This became especially noticeable on the test macOS env, where delays reached 10s causing tests to fall on deadline. On Linux, delays also increased, but by negligible amounts. This returns SN to using global 'passthrough' resolver. Fixes #3250. Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally https://rest.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/3250-1747219312/index.html