fix: send nil for admin_state_up when unspecified in ecl_network_port_v2 - #139
Open
kajiuray wants to merge 1 commit into
Open
fix: send nil for admin_state_up when unspecified in ecl_network_port_v2#139kajiuray wants to merge 1 commit into
kajiuray wants to merge 1 commit into
Conversation
resourcePortAdminStateUpV2 was always returning a non-nil *bool(false), causing "admin_state_up": false to be sent to the API even when the user omitted the field. This bypassed the server-side default of true, leaving ports in an administratively down state unexpectedly. Fix by using GetOkExists so that nil is returned when the field is not set, allowing eclcloud's omitempty to suppress the field and let the server apply its default (true). This aligns with the pattern already used by ecl_network_network_v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resourcePortAdminStateUpV2 was always returning a non-nil *bool(false), causing "admin_state_up": false to be sent to the API even when the user omitted the field. This bypassed the server-side default of true, leaving ports in an administratively down state unexpectedly.
Fix by using GetOkExists so that nil is returned when the field is not set, allowing eclcloud's omitempty to suppress the field and let the server apply its default (true). This aligns with the pattern already used by ecl_network_network_v2.