Merged
Conversation
jwaiton
force-pushed
the
add-WD1-processing
branch
from
27d632d to
fee38cc
Compare
bpalmeiro
reviewed
Jan 23, 2026
Collaborator
bpalmeiro
left a comment
bpalmeiro
left a comment
There was a problem hiding this comment.
First round of comments, have fun!
bpalmeiro
approved these changes
Jan 28, 2026
Collaborator
bpalmeiro
left a comment
bpalmeiro
left a comment
There was a problem hiding this comment.
Satisfied with changes. As usual, a bit of tech debt :P. Good job :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality of processing into MULE, with single channel decoding from waveDump 1 .dat files now being possible. Addresses #11 which will be resolved when this is complete.
The data is stored in h5 files with a storage path and name provided by the user. The h5 format is similar but does not match the wavedump 2 formatting, hence the need for malleable reader and writers (as introduced in #40). This will be resolved in future PRs to be equivalent across both.
This PR rests on top of #40, so should be merged after it.