Open
Conversation
reader() needed to allow writing while also being read. writer() was not allowing 'Overwrite = False' to function correctly when fixed_size was False
jwaiton
requested changes
Oct 17, 2025
jwaiton
requested changes
Feb 6, 2026
Member
jwaiton
left a comment
jwaiton
left a comment
There was a problem hiding this comment.
Small comments mostly, related to typos and other things.
The tests need a bit more thought, but we can figure that out together at some point.
two functions which check that window args dont overlap or exceed waveform length. Also comment changes made for clarity.
Tedsmith100
force-pushed
the
add-waveform-averager
branch
from
dec6950 to
d8b0034
Compare
jwaiton
requested changes
Feb 15, 2026
jwaiton
reviewed
Feb 22, 2026
Member
jwaiton
left a comment
jwaiton
left a comment
There was a problem hiding this comment.
Almost done! Just need to sit down and sort out the testing with hypothesis and then some not-so-fun rebasing and we'll be done :)
packs/ana/ana.py
Outdated
Comment on lines
+20
to
+33
|
|
||
| base_path = conf_args['save_path'] # Find the save path from config | ||
| path = base_path | ||
| base, ext = os.path.splitext(base_path) | ||
|
|
||
| counter = 1 # Stop overwrites by adding number to save path | ||
| while os.path.exists(path): | ||
| path = f"{base}_{counter}{ext}" | ||
| counter += 1 | ||
|
|
||
| with h5py.File(path, 'w') as f: # Save as a h5 | ||
| f.create_dataset('Average_waveform', data=avgwf) | ||
|
|
||
| print(f"Saved to: {path}") |
Member
There was a problem hiding this comment.
We can leave this for technical debt, but a simple test would be to run the code and ensure that the h5 file outputs what you expect based on the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes waveform averaging code in the form of ana.py, moves some functions around for cleanliness.