Skip to content

Update for the changed umbral-pre API #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Jan 7, 2023

umbral-pre switched to using serde throughout (nucypher/rust-umbral#110), which changes the ABI of protocol objects here.

  • Bumped umbral-pre to 0.8, rmp-serde to 1.x, pyo3 to 0.17
  • Bumped MSRV to 1.63 because the compilers before can't derive some types in some generic constructions in nucypher-core-wasm/src/lib.rs.
  • Major protocol versions bumped
  • Updated umbral.pyi
  • Updates for the changes in umbral-pre API
  • Using messagepack_serialize() as the standard serialization for signing purposes

@fjarri fjarri marked this pull request as draft January 7, 2023 00:49
@fjarri fjarri added the ABI Changes the format of serialized objects label Jan 7, 2023
@fjarri fjarri force-pushed the umbral-serde branch 3 times, most recently from f9d69bb to 29986f4 Compare January 17, 2023 05:47
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@5710d7d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage        ?   13.41%           
=======================================
  Files           ?       12           
  Lines           ?      425           
  Branches        ?        0           
=======================================
  Hits            ?       57           
  Misses          ?      368           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fjarri fjarri force-pushed the umbral-serde branch 6 times, most recently from 9d66881 to 201316a Compare January 17, 2023 07:23
@fjarri fjarri marked this pull request as ready for review January 17, 2023 07:41
@fjarri fjarri merged commit 411badc into nucypher:main Jan 17, 2023
@fjarri fjarri deleted the umbral-serde branch January 17, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABI Changes the format of serialized objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants