Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented May 23, 2024

Adding this job as a safeguard for the reasonably rare case when an RC is out for a dependency (e.g. we do test now for numpy 1.26.x and 2.1.dev, but not for the 2.0RC releases, while in theory, those may cause some issues).

We may want to consider swapping this job in the place of the one with the latest releases (as they will be practically identical when there are no RC releases for any of the dependencies).

To close #206

@bsipocz bsipocz added the infrastructure Issues relevant to infrasructure, rather than content label May 23, 2024
Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bsipocz - I agree with your take! It's probably not expected to be very common to have rc's for different minor versions, but it certainly doesn't hurt to add workflows that cover this case!

@rossbar rossbar merged commit 2ab567f into numpy:main May 23, 2024
@bsipocz bsipocz deleted the CI_add_predeps branch June 18, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues relevant to infrasructure, rather than content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: add an job for RC testing

2 participants