Updated team information, removed Joseph from the teams by his request - #1234
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR includes unexpected scope (new docs.sln) and appears to remove an additional team member from the matrix beyond what the PR title describes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the NUnit documentation repository’s team membership information by reformatting the membership matrix and moving a member to the former-members list, plus adds a new top-level Visual Studio solution file.
Changes:
- Reformats the membership matrix tables and moves Joseph Musser to a “Former members and honorable mentions” table with dates.
- Adds a new
docs.slnsolution referencing the snippets projects.
File summaries
| File | Description |
|---|---|
| docs/articles/developer-info/The-Teams.md | Reformats the team membership tables and updates the roster (including adding a former-members table with date ranges). |
| docs.sln | Adds a new Visual Studio solution for the repo’s snippet projects. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+4
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.5.2.0 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 |
Comment on lines
+9
to
+12
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Snippets.NUnit", "docs\snippets\Snippets.NUnit\Snippets.NUnit.csproj", "{3A3A7B63-9801-D598-8E49-6D195177065B}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Snippets.NUnitLite", "docs\snippets\Snippets.NUnitLite\Snippets.NUnitLite.csproj", "{E9CEC5A3-A316-7CA6-DE58-EC295C3BF92A}" | ||
| EndProject |
Comment on lines
+68
to
+69
| |[Chris Maddock](https://github.com/ChrisMaddock) :gb: | 2016 - 2022 | | ||
| |[Joseph Musser](https://github.com/jnm2) :us: | 2017 - 2026 | |
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Updated team information, removed Joseph from the teams by his request df6d414
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.