Repository navigation
Use the public agent provider contract - #1935
Closed
oznetmaster wants to merge 1 commit into
Closed
oznetmaster wants to merge 1 commit into
oznetmaster wants to merge 1 commit into
Conversation
Consume the published API beta.101.2, remove the engine-local duplicate, and adopt ReturnAgent throughout providers, callers and test helpers. Retain existing wire commands and provider ownership behavior. Prepared by Neil Colvin with assistance from OpenAI Codex.
Collaborator
Author
|
#1936 has incorporated the public provider API adoption and renamed the coordinator to TestAgentService. The additional five public-contract identity regressions from this draft are retained in the refreshed #1934. Closing this draft as superseded avoids competing API-adoption changes; it does not discard those regressions or the remote-provider work. Prepared by Neil Colvin with assistance from OpenAI Codex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public ITestAgentProvider contract is now merged in nunit/nunit.engine.api#22. Remove the engine's internal copy so the engine and independently compiled providers share one type identity, and adopt the agreed GetAgent / ReturnAgent names throughout the built-in providers, coordinator, runner and test-server helpers.
This is based on current main after merged #1933 (341a47c). The originating-provider ownership and local shutdown correction remain intact. Existing launcher/registration interfaces, wire command names, provider order, and default local selection are unchanged. TestAgency is not renamed here; the proposed TestAgentService rename remains separate. The unused legacy service receives the required member rename but is not activated or otherwise refactored.
Dependency
Use the actual public MyGet NUnit.Engine.Api 4.0.0-beta.101.2. A downloaded package independently verifies repository commit 900dc3829484f2b20ccb20f547d407f6e6e508d4 (the #22 merge), the public ReturnAgent contract and both library targets. NuGet source mapping routes only this exact package ID to MyGet; other dependencies remain on their existing sources. No package is rebuilt or overwritten. Please coordinate the eventual NuGet release pin; this specific intermediate build follows the current development base and is not described as a stable public release.
Validation on Windows
The initial whole-solution build exposed a missing installed .NET 7 FrameworkList.xml in two unrelated standalone mock-fixture targets. That failed attempt is retained. The supported engine/console/common target builds pass separately; no machine-wide SDK or production-source workaround was made. This PR does not claim a successful all-fixture solution build or fresh Linux/macOS, GUI, adapter or physical-backend validation.
Prepared by Neil Colvin with assistance from OpenAI Codex.