Fix SplitterStyle destruction (#743)

nuttyartist · Feb 9, 2025 · f7c03bd · f7c03bd
1 parent b3b0a24
commit f7c03bd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
@@ -491,7 +491,7 @@ void MainWindow::setupMainWindow()
 #endif
     ui->listviewLabel1->setFont(titleFont);
     ui->listviewLabel2->setFont(titleFont);
-    m_splitterStyle = new SplitterStyle();
+    m_splitterStyle = new SplitterStyle(this);
     m_splitter->setStyle(m_splitterStyle);
     m_splitter->setHandleWidth(0);
     setNoteListLoading();

diff --git a/src/splitterstyle.cpp b/src/splitterstyle.cpp
@@ -1,6 +1,9 @@
 #include "splitterstyle.h"
 
-SplitterStyle::SplitterStyle() { }
+SplitterStyle::SplitterStyle(QObject *parent) : QProxyStyle()
+{
+    setParent(parent); // to ensure proper object destruction
+}
 
 void SplitterStyle::drawControl(ControlElement element, const QStyleOption *opt, QPainter *p,
                                 const QWidget *w) const

diff --git a/src/splitterstyle.h b/src/splitterstyle.h
@@ -5,13 +5,13 @@
 
 class SplitterStyle : public QProxyStyle
 {
+    Q_OBJECT
 public:
-    SplitterStyle();
+    SplitterStyle(QObject *parent);
 
-    // QStyle interface
 public:
-    virtual void drawControl(ControlElement element, const QStyleOption *opt, QPainter *p,
-                             const QWidget *w) const override;
+    void drawControl(ControlElement element, const QStyleOption *opt, QPainter *p,
+                     const QWidget *w) const override;
 };
 
 #endif // SPLITTERSTYLE_H