Skip to content

Conversation

atinux
Copy link
Contributor

@atinux atinux commented Oct 2, 2025

Not sure if this is worth having as breaking change as it is a very advanced usaged.

Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
docus Ready Ready Preview Oct 6, 2025 8:59am

@atinux atinux requested a review from larbish October 2, 2025 18:40
Copy link

pkg-pr-new bot commented Oct 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/create-docus@1194
npm i https://pkg.pr.new/docus@1194

commit: 3e9a5aa

@larbish larbish merged commit bac9aa0 into main Oct 6, 2025
3 of 4 checks passed
@larbish larbish deleted the layouts/perf branch October 6, 2025 08:57
@sandros94
Copy link
Contributor

This reverts #1187 and forces use definePageMeta on each custom layout and custom page. Am I missing any advantage of having a hardcoded header and footer in the app.vue compared to nested layouts? 🤔

@larbish
Copy link
Collaborator

larbish commented Oct 10, 2025

@sandros94 The old way of handling it caused the docs aside to be mounted twice. You can still create your own layout with this implementation and simply disable the header and footer there.

@sandros94
Copy link
Contributor

@sandros94 The old way of handling it caused the docs aside to be mounted twice. You can still create your own layout with this implementation and simply disable the header and footer there.

Rethinking about this, since I never use the provided header and footer, I could simply rewrite them and let Nuxt use the ones from the local project instead of docus' layer. Indeed there should be plenty of workarounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants