feat: add cookie attributes #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-color-mode canceled.
|
|
May i ask to improve naming? Would be nice to use |
tasiotas
commented
Jan 22, 2025
Author
tasiotas
left a comment
tasiotas
left a comment
There was a problem hiding this comment.
cookieAttribs renamed to cookieAttrs
buihanh2304
reviewed
Feb 28, 2025
Contributor
|
I'm wondering, I don't think domain is very useful though, but what about just forcing the path to be |
Open
|
any updates? |
|
lgtm, tried locally with the cookieAttrs changes and that pesky "Some cookies are misusing the recommended “SameSite“ attribute" is gone |
marcel-bitfly
added a commit
to gobitfly/beaconchain
that referenced
this pull request
Oct 15, 2025
Saving the current `color mode` in a cookie to avoid `hydration issues`, as this way the `server` already knows the current `color mode`. It was necessary to use `useCookie()` to save the `color mode` instead of the `storage setting` of `nuxtjs/color-mode`, as the cookie value otherwise will be applied to the current `/path`. Resulting in different `color modes` for different `paths. See: nuxt-modules/color-mode#301
marcel-bitfly
added a commit
to gobitfly/beaconchain
that referenced
this pull request
Oct 15, 2025
Saving the current `color mode` in a cookie to avoid `hydration issues`, as this way the `server` already knows the current `color mode`. It was necessary to use `useCookie()` to save the `color mode` instead of the `storage setting` of `nuxtjs/color-mode`, as the cookie value otherwise will be applied to the current `/path`. Resulting in different `color modes` for different `paths. See: nuxt-modules/color-mode#301
marcel-bitfly
added a commit
to gobitfly/beaconchain
that referenced
this pull request
Oct 15, 2025
Saving the current `color mode` in a cookie to avoid `hydration issues`, as this way the `server` already knows the current `color mode`. It was necessary to use `useCookie()` to save the `color mode` instead of the `storage setting` of `nuxtjs/color-mode`, as the cookie value otherwise will be applied to the current `/path`. Resulting in different `color modes` for different `paths. See: nuxt-modules/color-mode#301
marcel-bitfly
added a commit
to gobitfly/beaconchain
that referenced
this pull request
Oct 15, 2025
Saving the current `color mode` in a cookie to avoid `hydration issues`, as this way the `server` already knows the current `color mode`. It was necessary to use `useCookie()` to save the `color mode` instead of the `storage setting` of `nuxtjs/color-mode`, as the cookie value otherwise will be applied to the current `/path`. Resulting in different `color modes` for different `paths. See: nuxt-modules/color-mode#301
marcel-bitfly
added a commit
to gobitfly/beaconchain
that referenced
this pull request
Oct 16, 2025
Saving the current `color mode` in a cookie to avoid `hydration issues`, as this way the `server` already knows the current `color mode`. It was necessary to use `useCookie()` to save the `color mode` instead of the `storage setting` of `nuxtjs/color-mode`, as the cookie value otherwise will be applied to the current `/path`. Resulting in different `color modes` for different `paths. See: nuxt-modules/color-mode#301
Collaborator
|
partial support landed via #320, but we can iterate here to allow configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
none
❓ Type of change
📚 Description
I added
cookieAttribsto the module config. This allows to specify any cookie attribute for further configuration. Now we can specifypath,domainetc. so that color-mode works across subdomains.Thank you