Skip to content

fix: stub helper utility with no-ops in test mode #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2025
Merged

fix: stub helper utility with no-ops in test mode #325

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6860fa7
create fallback helper for breaking vitest tests
Sep 26, 2025
5f54803
save
Sep 26, 2025
848ff61
Merge remote-tracking branch 'origin/main' into janhoogeveen/main
danielroe Nov 11, 2025
00e1dc8
fix: only apply empty object in test mode
danielroe Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/runtime/plugin.client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,27 @@ import type { ColorModeInstance } from './types'
import { defineNuxtPlugin, isVue2, isVue3, useRouter, useHead, useState } from '#imports'
import { globalName, storageKey, dataValue, disableTransition, storage } from '#color-mode-options'

// Initialise to empty object to avoid hard error when hydrating app in test mode
const helper = (window[globalName] || {}) as unknown as {
type Helper = {
preference: string
value: string
getColorScheme: () => string
addColorScheme: (className: string) => void
removeColorScheme: (className: string) => void
}

let helper = window[globalName] as unknown as Helper

// Initialise to object with defaults and no-ops to avoid hard error when hydrating app in test mode
if (import.meta.test && !helper) {
helper = {
preference: 'light',
value: 'light',
getColorScheme: () => 'light',
addColorScheme: () => {},
removeColorScheme: () => {},
}
}

export default defineNuxtPlugin((nuxtApp) => {
const colorMode = useState<ColorModeInstance>('color-mode', () => reactive({
// For SPA mode or fallback
Expand Down