Skip to content

fix(ContextMenu/DropdownMenu): remove any from proxySlots #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

Norbiros
Copy link
Contributor

@Norbiros Norbiros commented Mar 19, 2025

πŸ”— Linked issue

Related to #3405

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR should fix annoying issue with vue-tsc, finally allowing for use of vue-tsc: 3.0.0-alpha.2 and nuxt ui without any patches.

I am not sure why there was even any in the first place. It will be properly solved in #3331.

Note: We can't still update vue-tsc in @nuxt/ui, it fails with 117 errors (sometimes 15 so idk), so maybe we shouldn't close linked issue...

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Mar 19, 2025

npm i https://pkg.pr.new/@nuxt/ui@3623

commit: f398aef

@benjamincanac benjamincanac changed the title fix(ContextMenu, DropdownMenu): Remove any from proxySlots fix(ContextMenu/DropdownMenu): remove any from proxySlots Mar 19, 2025
@benjamincanac benjamincanac merged commit 764c41a into nuxt:v3 Mar 19, 2025
2 checks passed
@Norbiros Norbiros deleted the fix/context-menu-types branch March 19, 2025 21:05
@benjamincanac benjamincanac added the v3 #1289 label Apr 4, 2025
rdjanuar pushed a commit to rdjanuar/ui that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants