Skip to content

fix(useOverlay)!: correct spelling of unmount function #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v3
Choose a base branch
from

Conversation

genu
Copy link
Member

@genu genu commented May 2, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This fixes typo in method name. unMount should be unmount

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented May 2, 2025

npm i https://pkg.pr.new/@nuxt/ui@4051

commit: ab40bc6

@benjamincanac benjamincanac changed the title fix(OverlayProvider): correct spelling of unmount function fix(useOverlay): correct spelling of unmount function May 2, 2025
@benjamincanac benjamincanac changed the title fix(useOverlay): correct spelling of unmount function fix(useOverlay)!: correct spelling of unmount function May 2, 2025
@genu genu marked this pull request as ready for review May 2, 2025 20:16
Co-authored-by: Benjamin Canac <[email protected]>
@benjamincanac
Copy link
Member

@genu I'll wait to merge this so we can continue releasing patches if needed. I'd rather introduce this breaking change in a minor release.

@genu
Copy link
Member Author

genu commented May 4, 2025

I agree

@benjamincanac benjamincanac added the v3 #1289 label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants