Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug to move braille to next line in UIA documents #17401

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nvdaes
Copy link
Collaborator

@nvdaes nvdaes commented Nov 15, 2024

Link to issue number:

Fixes #17251

Summary of the issue:

In some UIA documents which end with an empty line, braille cannot be moved to the last line.

Description of user facing changes

Braille can be moved to the last line in all UIA documents.
If the braille move to next line command is run from the last line, the cursor will be moved to the last character.

Description of development approach

A shouldCollapseToEnd variable has been added to the method to move braille to the next line, to determine if text info should be collapsed to end. When braille is not moved to the next line using other procedures, shouldCollapseToEnd is set to True and text info is collapsed to end.

Testing strategy:

Tested manually in Notepad.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

braille: cannot move to last empty line with braille scrolling keys in notepad
1 participant