Fix bug to move braille to next line in UIA documents #17401
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17251
Summary of the issue:
In some UIA documents which end with an empty line, braille cannot be moved to the last line.
Description of user facing changes
Braille can be moved to the last line in all UIA documents.
If the braille move to next line command is run from the last line, the cursor will be moved to the last character.
Description of development approach
A
shouldCollapseToEnd
variable has been added to the method to move braille to the next line, to determine if text info should be collapsed to end. When braille is not moved to the next line using other procedures,shouldCollapseToEnd
is set to True and text info is collapsed to end.Testing strategy:
Tested manually in Notepad.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary