Skip to content

feat: improve entry display and add highlighting #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cvigilv
Copy link

@cvigilv cvigilv commented Apr 13, 2025

  • Adjusted width of location and tags columns
  • Added separate column for tags
  • Implemented syntax highlighting for different parts of the entry
  • Added headline level to the entry object for use in highlighting
  • Modified make_display function to use the new structure and highlighting

- Adjusted width of location and tags columns
- Added separate column for tags
- Implemented syntax highlighting for different parts of the entry
- Added headline level to the entry object for use in highlighting
- Modified make_display function to use the new structure and highlighting
@cvigilv
Copy link
Author

cvigilv commented Apr 13, 2025

Before:

Light Dark
Screenshot 2025-04-13 at 6 37 18 PM Screenshot 2025-04-13 at 6 37 34 PM

After:

Light Dark
Screenshot 2025-04-13 at 5 55 25 PM Screenshot 2025-04-13 at 5 55 07 PM

EDIT: Added "before" and "after" sections to show what this PR implements

@cvigilv
Copy link
Author

cvigilv commented Apr 13, 2025

I was thinking that maybe I could add some user configuration for the following:

  1. Column-view (as shown here) or continuous-view (as previously defined)
  2. Headline highlight group (currently defined as @org.headline.level<LEVEL>)
  3. Tags highlight group (currently defined as @org.tag)
  4. Column-view width (currently defined as {"file" = 16, "tags" = 24, "headline" = "remaining")

Let me know what you think, so I can proceed on implementing those user options and the continuous view we had before.

@cvigilv
Copy link
Author

cvigilv commented Apr 16, 2025

I was thinking on maybe adding the CATEGORY in the picker and allow the user to define (1) components to see on search and (ii) width of the components.

LMKWYT

@seflue
Copy link
Collaborator

seflue commented Apr 17, 2025

Thank you for yor PR @cvigilv . I will try to have a look at it over the next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants