fix(#3143): actions.open_file.window_picker.exclude applies when not using window picker #3144
+14
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
approved these changes
Jun 14, 2025
There was a problem hiding this comment.
Tested OK via open_file.window_picker.exclude variants.
Many thanks for your contribution @LucasMABF !
alex-courtis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that when using
open.no_window_picker, the fallback window selection respects thewindow_picker.excludeconfiguration.Previously, if no window picker was used, nvim-tree would open the file in the last active window, even if that window matched an excluded type (e.g., a terminal).
Now it sets the fallback window as the first available usable window, not excluded in the configuration, which can prevent undesired behavior.
Related Issue
Fixes #3143
Additional Notes
I removed the
first_win_idfunction to avoid redundant calls tousable_win_ids. Happy to adjust if you'd like to keep it.Let me know if there’s any other adjustment or further cleanup you’d like.
Appreciate your time and review!