Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make max_lines accept percentage (of window height) or function #412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guilhas07
Copy link

Closes #275

Add the possibility of providing a percentage string of max_lines e.g., "5%"; or a function that returns a number or a percentage string.

Notes:

  • Looking at the config fields I see that max_lines should be an integer, but I couldn't force that ( due to not having math.type in lua 5.1) so I just checked against number. Is this a problem?
  • Related to type annotations. I don't know if it is because of my local lsp config, but the max_lines type is not inferred correctly.
  • Some formatting changes were made. I assume it's because of the stylua local file and not my config, tell me if I should revert them.

If there is something that I need to change let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make max_lines accept percentage (of window height)
1 participant