feat: make max_lines accept percentage (of window height) or function #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275
Add the possibility of providing a percentage string of
max_lines
e.g., "5%"; or a function that returns a number or a percentage string.Notes:
max_lines
should be aninteger
, but I couldn't force that ( due to not havingmath.type
in lua 5.1) so I just checked againstnumber
. Is this a problem?max_lines
type is not inferred correctly.If there is something that I need to change let me know!