Revert multiwindow support #523
Open
+88
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis6991
force-pushed
the
revert/multiwindow
branch
from
c11e9db
to
296fc73
Compare
lewis6991
force-pushed
the
revert/multiwindow
branch
from
296fc73
to
f0bc306
Compare
|
Do you have any specific suggestions? Linking the lifespan of two windows in neovim seems to be quite challenging. The only potential way I see to minimize bugs for users not using multiwindow is to maintain the context in a single variable, as was previously done. However, I'm unsure how to bypass the bug-fixing phase when the multiwindow is enabled (maybe writing stress tests for different scenarios?) |
|
https://github.com/lewis6991/satellite.nvim manages multi window pretty well. Never had an issue with it. Maybe you can take a look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too buggy, needs more development.
This reverts commit f1b7285.
This reverts commit e7fdb4c.
This reverts commit 9e36638.
This reverts commit 6cba006.
This reverts commit bf6386d.
This reverts commit 3de5708.
This reverts commit 63374d1.