Skip to content

Conversation

enlightened88
Copy link

No description provided.

@freedomfraternity1822-ux

This comment was marked as spam.

@freedomfraternity1822-ux

This comment was marked as spam.



# Node Version Manager [![Build Status](https://app.travis-ci.com/nvm-sh/nvm.svg?branch=master)][3] [![nvm version](https://img.shields.io/badge/version-v0.40.3-yellow.svg)][4] [![CII Best Practices](https://bestpractices.dev/projects/684/badge)](https://bestpractices.dev/projects/684)
# Node Version Manager [![Build Status](https://github.com/nvm-sh/nvm/actions/workflows/github-code-scanning/codeql/badge.svg)][3] [![nvm version](https://img.shields.io/badge/version-v0.40.3-yellow.svg)][4] [![CII Best Practices](https://bestpractices.dev/projects/684/badge)](https://bestpractices.dev/projects/684)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this change removes the travis badge (which is still needed) and adds an incomplete actions badge (which only covers the codeql workflow, not all the tests)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb I've already tried everything, I can only suggest this one https://img.shields.io/badge/build-passing-green.svg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not the image that matters, it’s whether it properly reflects the status of all GitHub actions on that sha.

And, we must keep the Travis badge while we have tests running on it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then just leave everything as it is, no other option

@ljharb ljharb marked this pull request as draft October 13, 2025 21:18
@freedomfraternity1822-ux

This comment was marked as spam.

@enlightened88 enlightened88 requested a review from ljharb October 14, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants