Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iMXRT700] Rename the GPIO peripheral to RGPIO so that it matches the naming scheme of the iMXRT1180 #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Masmiseim36
Copy link
Contributor

Prerequisites

  • I have checked latest main branch and the issue still exists.
  • I did not see it is stated as known-issue in release notes.
  • No similar GitHub issue is related to this change.
  • My code follows the commit guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

Describe the pull request
Rename the GPIO peripheral to RGPIO so that it matches the naming scheme of the iMXRT1180. The same IP should be named identically so that it can be addressed by the same driver.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    May break sw which uses the peripheral names of the current version. But simplifies using the existing driver for the RGMI-Peripheral

Tests

Still open. The current releases for the iMXRT700 family are still somewhat incomplete and examples are missing

… naming scheme of the iMXRT1180. The same IP should be named identically so that it can be addressed by the same driver.
@ChayGuo
Copy link

ChayGuo commented Feb 24, 2025

Thanks for the suggestion, but the changes may can't be accepted. The reasons are,

  1. The GPIO instance & registers name, IRQ name in header file are aligned with RT700 Reference Manual. They are called GPIO in Reference Manual and all other documentations.
  2. The GPIO on iMXRT700 is the same IP with MCXN947 and some other Kinetis devices, which are using "nxp,kinetis-gpio" in Zephyr. So RT700 is also using "nxp,kinetis-gpio" not "nxp,imx-rgpio". Currently, iMXRT700 Zephyr support has been up streamed, we are using "nxp, kinetis-gpio".
  3. Those Changes in header have big impact on MCUXpresso SDK and Config tools.
    Per the above reasons, we can't accept the changes here. Can you help clarify what's the issue you are facing without the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants