Schedule campaign events via endpoint #5915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
better_campaign_events_pt1
branch
3 times, most recently
from
7dd90cd to
c4007b6
Compare
add new fields to support invalidating fires without recreating events.
rowanseymour
force-pushed
the
better_campaign_events_pt1
branch
from
c4007b6 to
fae73d5
Compare
rowanseymour
commented
Feb 28, 2025
|
|
||
| from . import APITest | ||
|
|
||
|
|
||
| class DefinitionsEndpointTest(APITest): | ||
| def test_endpoint(self): | ||
| @mock_mailroom | ||
| def test_endpoint(self, mr_mocks): |
There was a problem hiding this comment.
because we're no longer calling real mailroom.. had to rewrite this test to not assume imports setup flow dependencies correctly.. better this way.. tests shouldn't be calling real mailroom
rowanseymour
force-pushed
the
better_campaign_events_pt1
branch
from
0cb1f2a to
b6ba429
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5915 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 508 508
Lines 25286 25283 -3
=========================================
- Hits 25286 25283 -3 ☔ View full report in Codecov by Sentry. |
rowanseymour
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches rescheduling of campaign events to use new mailroom endpoint
Requires nyaruka/mailroom#501
.. unfortunately triggered a lot of test rewriting because now tests creating campaign events have to mock mailroom but we still have a lot of tests that rely on real mailroom for flow imports