Skip to content

Remove OCaml related code from mina-tree #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2025
Merged

Remove OCaml related code from mina-tree #1646

merged 3 commits into from
Dec 4, 2025

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Nov 14, 2025

Fix #1235

@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 42ec1eb790aa3303b8961b62a02bc3adc375db59

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 42ec1eb790aa3303b8961b62a02bc3adc375db59)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@dannywillems dannywillems self-assigned this Nov 14, 2025
@dannywillems dannywillems moved this to Done in Rust node Nov 14, 2025
@dannywillems dannywillems force-pushed the dw/ledger-rm-ocaml branch 2 times, most recently from a95d0c4 to 7c8764e Compare November 14, 2025 20:09
@dannywillems dannywillems force-pushed the dw/ledger-rm-ocaml branch 2 times, most recently from 8aeda66 to 586b30b Compare December 2, 2025 15:24
@dannywillems dannywillems changed the title Remove OCaml related code and fix taplo installation Remove OCaml related code from mina-tree Dec 2, 2025
@dannywillems dannywillems moved this from Done to In Progress in Rust node Dec 2, 2025
@dannywillems dannywillems mentioned this pull request Dec 2, 2025
Closed
richardpringle
richardpringle approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

ledger/src/account/legacy.rs
@@ -1,13 +1,10 @@
use std::borrow::Cow;

use super::common::*;
Copy link
Contributor

@richardpringle richardpringle Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross... we need a lint preventing * imports.

Copy link
Member Author

@dannywillems dannywillems Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!!

ledger/src/lib.rs
mod cache;

#[cfg(all(not(target_family = "wasm"), feature = "ocaml-interop"))]
mod ffi;
Copy link
Contributor

@richardpringle richardpringle Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

ledger/src/proofs/mod.rs
Copy link
Contributor

@richardpringle richardpringle Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we like code to look the same way 🏆

@dannywillems dannywillems moved this from In Progress to In Review in Rust node Dec 3, 2025
@dannywillems dannywillems merged commit 62fd29f into develop Dec 4, 2025
141 of 144 checks passed
@dannywillems dannywillems deleted the dw/ledger-rm-ocaml branch December 4, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardpringle richardpringle richardpringle approved these changes

Assignees

@dannywillems dannywillems

Labels

None yet

Projects

Rust node
Status: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove fork of ocaml-interop from sebastiencs

3 participants

@dannywillems @richardpringle