Draft
Conversation
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
- Coverage 48.60% 48.59% -0.01%
==========================================
Files 225 225
Lines 16128 16128
==========================================
- Hits 7839 7838 -1
- Misses 8229 8230 +1
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bcfbd8c to
484d5a2
Compare
484d5a2 to
723fcea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR.
Testing PR for buildkite errors.
jobs are not there anymore in build info json if you are logged out, e.g.
https://buildkite.com/oasisprotocol/oasis-core-ci/builds/16317.json
The CI github action tries to download a specific artifact from a buildkite job from a build named "Build runtimes...". We first fetch the build info here:
https://github.com/oasisprotocol/oasis-sdk/blob/main/tests/download-artifacts.sh#L58
Then we extract the job ID here:
https://github.com/oasisprotocol/oasis-sdk/blob/main/tests/download-artifacts.sh#L66
And since the job ID is not there anymore, it fails one line lower.
Reported upstream to buildkite support.