feat: add optional runtimeclassname#410
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
7f9f6cc to
8788bc5
Compare
|
A general comment about version bumping, we internally set up a workflow to deal with it instead of requiring each dev to guess the next available version. It lets us merge things much faster. Devs just declare the kind of version bump they want with a file in a certain directory and it is used to generate the commit for the version bump (different directories for different kinds of bumps). That same thing could also manage the changelog bit which will always conflict here. Anyway, I'll see if I can find time today or Monday for this. But I can't make guarantees. |
|
The two actions that work together are more or less: The code more or less works like this: on:
push:
branches:
- main*
pull_request:
permissions:
contents: read
jobs:
ci:
if: github.event_name == 'pull_request' || !contains(github.actor, 'something')
runs-on: ubuntu-latest
timeout-minutes: 10
permissions:
contents: read
id-token: write
steps:
- name: Checkout with push key
if: github.event_name == 'push'
uses: actions/checkout@v6
with:
ssh-key: "${{ secrets.PUSH_KEY }}"
- name: Bump Version
if: github.event_name == 'push'
uses: GarnerCorp/build-actions/bump-version@main
id: version
with:
version-type: "node"
version-file-path: "package.json"
git-name: "something"
git-email: "something@example.com"
major: changelogs/major
minor: changelogs/minorThere's some fancy dancing involved, and we don't use it for public repositories, so we aren't particularly worried about things, but, ... You could do it in various other forms, e.g. having a release workflow that only runs on dispatch or something. I've been meaning to do a blog post writing up this workflow (probably on dev.to), but I haven't yet, so this is probably the first time I've publicly described it.
|
Description
Add
runtimeClassNameto enable using oauth2-proxy with gvisor (see https://gvisor.dev/docs/tutorials/kubernetes/#wordpress-deployment)Checklist: