Skip to content

fix(code-reviewer): require tool verification before asserting facts about external systems #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jamie-BitFlight wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

fix(code-reviewer): require tool verification before asserting facts about external systems #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions skills/requesting-code-review/code-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,23 @@ You are reviewing code changes for production readiness.
4. Categorize issues by severity
5. Assess production readiness

## Verification Before Assertion

**Before making ANY factual claim about external systems, versions, or behavior — verify it with a tool.**

Training data is a source of *questions to ask*, not *answers to assert*.

| Claim type | Required verification |
|---|---|
| GitHub Actions version | `gh release list --repo <owner>/<action> --limit 1` |
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh release list --repo <owner>/<action> --limit 1 is not a reliable way to determine the latest available GitHub Action version: many action repos don’t publish GitHub Releases (only tags), --limit 1 returns the most recently created release (not necessarily highest semver), and it may pick a prerelease. Consider updating the guidance to verify via tags (e.g., gh api repos/<owner>/<repo>/tags --paginate / git ls-remote --tags) and/or the action’s Marketplace page, and clarify how to choose a stable major tag (vN) vs a pinned patch (vN.N.N).

Suggested change
| GitHub Actions version | `gh release list --repo <owner>/<action> --limit 1` |
| GitHub Actions version | Use tags: `gh api repos/<owner>/<action>/tags --paginate` or `git ls-remote --tags https://github.com/<owner>/<action>.git`, and/or check the Action’s Marketplace page. Choose an appropriate tag: stable major (`vN`) or pinned patch (`vN.N.N`). |

Copilot uses AI. Check for mistakes.
| PyPI package version | `pip index versions <package>` or check pypi.org |
| npm package version | `npm view <package> version` |
| Any "X doesn't exist" | Prove it with a command, not training data |

**The failure mode:** Asserting "v6 doesn't exist" without checking caused a real regression — correct versions were downgraded to stale ones, wasting multiple agent turns to fix.

**Red flag:** If you are about to write "X does not exist" or "the current stable version is Y" — STOP. Run a verification command first.

## What Was Implemented

{DESCRIPTION}
Expand Down
Loading