Skip to content

fix(writing-plans): avoid invalid placeholder chars in plan filenames #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stablegenius49 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(writing-plans): avoid invalid placeholder chars in plan filenames #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion skills/writing-plans/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ Assume they are a skilled developer, but know almost nothing about our toolset o

**Context:** This should be run in a dedicated worktree (created by brainstorming skill).

**Save plans to:** `docs/plans/YYYY-MM-DD-<feature-name>.md`
**Save plans to:** `docs/plans/YYYY-MM-DD-feature-name.md`

Filename rules (to avoid tool/path errors across macOS/Linux/Windows):
- Replace `feature-name` with a real lowercase slug (e.g., `oauth-login`, `invoice-export`)
- Use only: `a-z`, `0-9`, and hyphens (`-`)
- Never leave placeholder characters like `<` `>` in the actual filename
Comment on lines +20 to +23
Copy link

@coderabbitai coderabbitai bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for filename patterns with angle brackets in brainstorming skill
rg -n -C3 'YYYY-MM-DD' skills/brainstorming/SKILL.md

Repository: obra/superpowers

Length of output: 797

Update brainstorming skill to match new filename rules.

The brainstorming skill still uses angle bracket placeholders in filename patterns (lines 30 and 81: docs/plans/YYYY-MM-DD-<topic>-design.md), which contradicts the new rule on line 23 that states "Never leave placeholder characters like < > in the actual filename." Users following the brainstorming skill could create files with invalid filenames and encounter tool errors.

Update both instances to use plain alphanumeric slugs (e.g., docs/plans/YYYY-MM-DD-topic-design.md) and add the filename rules to the brainstorming skill's documentation for consistency.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@skills/writing-plans/SKILL.md` around lines 20 - 23, The brainstorming skill
uses angle-bracket placeholders in filename patterns — specifically the pattern
"docs/plans/YYYY-MM-DD-<topic>-design.md" — which violates the filename rules;
update both occurrences to use a plain slug (e.g.,
"docs/plans/YYYY-MM-DD-topic-design.md") and add the filename rules (use
lowercase a-z, 0-9, hyphens, no `<` or `>`) into the brainstorming skill
documentation in SKILL.md so users see the constraints; search for the pattern
"docs/plans/YYYY-MM-DD-<topic>-design.md" and replace it with
"docs/plans/YYYY-MM-DD-topic-design.md" and append or integrate the filename
rules paragraph near the skill instructions.


## Bite-Sized Task Granularity

Expand Down