Multiple type building improvements/fixes #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue (if applicable):
N/A
Description:
This PR changes/fixes a few things in relation to the type build script:
ScenesCollection
typedef wasn't defined yet.error
event type with (mostly) correct types. This makes add error event to types #217 redundant and is a little more specific as the type returned should be more than a string, as the underlying error is a normal WebSocket error.Output
typedef not being used correctly.Array<Object>
parameters to actually have correct types; before they seemed to only have the type of their last property as the array type (for examplestring[]
).ExecuteBatch
request; you could probably have really good types depending on what is supplied/received for therequest-type
but not sure of the best way to do that; presumably with the type mapping?Before Lange/Alex Van Camp went MIA, he did mention to me that something would need to be "fixed" with the type building for this library, although that message was in a Discord server that was deleted/I no longer have access to, so I'm not sure if these were the fixes, or if something more needs to be done. It appears to build just fine now and don't think there were any changes in
obs-websocket
itself that should make a difference?