Skip to content

Fil/onramp review #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Fil/onramp review #1805

merged 4 commits into from
Nov 12, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Nov 8, 2024

Review of #1745.
I reformatted a bit to help me read the changes. Found (and fixed) a small bug in error handling.

Fil added 4 commits November 8, 2024 14:02
fixes an uncaught Error ('Setting source repository for continuous deployment failed' was never reached)
Copy link
Contributor

@tophtucker tophtucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup!! 🙏

@tophtucker tophtucker merged commit 3e5e669 into toph/onramp Nov 12, 2024
@tophtucker tophtucker deleted the fil/onramp-review branch November 12, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants