Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added permissions for lint & type check workflows #438

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Added permissions for lint & type check workflows #438

merged 2 commits into from
Feb 18, 2025

Conversation

kelmag
Copy link
Member

@kelmag kelmag commented Feb 18, 2025 •
edited
Loading

What does this do?

  • Added permissions for lint & type check workflows

Context :

  • GitHub added some security checks. Every workflow that requires adding comments to a pull request (PR) or annotations—such as Reviewdog—needs this permission

@kelmag kelmag requested a review from yjose February 18, 2025 14:42
@kelmag kelmag self-assigned this Feb 18, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2025 •
edited
Loading

✅ Deploy Preview for obytes-starter canceled.

Name Link
🔨 Latest commit 80db1f4
🔍 Latest deploy log https://app.netlify.com/sites/obytes-starter/deploys/67b4aa8599108400089e1649

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 40%
 39.33% (188/478) 33.93% (75/221) 26.48% (49/185)

😎 Tests Results

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 27.815s ⏱️
👀 Tests Details • (40%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files39.3333.9326.4840.17 
report-only-changed-files is enabled. No files were changed in this commit :)

yjose
yjose requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@yjose yjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be added to expo doctor as well i think

@kelmag kelmag requested a review from yjose February 18, 2025 15:43
@yjose yjose merged commit 38fc970 into master Feb 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjose yjose yjose approved these changes

Assignees

@kelmag kelmag

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelmag @yjose