Skip to content

test(spawn): reproduce lost exec errors with closed standard fds #15548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgrinberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(spawn): reproduce lost exec errors with closed standard fds #15548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions otherlibs/stdune/test/spawn/tests.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,36 @@ let%expect_test "non-existing program" =
|}]
;;

let%expect_test "exec failure returns if standard descriptors are closed" =
if Platform.OS.value = Linux
then
assert (
match Unix.fork () with
| 0 ->
let dev_null = Unix.openfile "/dev/null" [ O_RDWR ] 0 in
Unix.close Unix.stdin;
Unix.close Unix.stdout;
(match
Spawn.spawn
()
~prog:"/doesnt-exist"
~argv:[ "blah" ]
~stdin:dev_null
~stdout:dev_null
~stderr:dev_null
with
| pid ->
(match Proc.wait (Pid pid) [] with
| Some _ -> Unix._exit 0
| None -> Unix._exit 2)
| exception Unix.Unix_error _ -> Unix._exit 1)
| child ->
(match Proc.wait (Pid (Pid.of_int_exn child)) [] with
| Some { status = WEXITED 0; _ } -> true
| Some _ | None -> false));
[%expect {||}]
;;

let%expect_test "non-existing dir" =
show_raise (fun () ->
Spawn.spawn
Expand Down
Loading