Skip to content

feat(describe): Include anonymous actions in dune rules - #15586

Draft
NatKarmios wants to merge 14 commits into
ocaml:mainfrom
NatKarmios:describe-rules-anon-actions-2
Draft

feat(describe): Include anonymous actions in dune rules#15586
NatKarmios wants to merge 14 commits into
ocaml:mainfrom
NatKarmios:describe-rules-anon-actions-2

Conversation

@NatKarmios

Copy link
Copy Markdown
Contributor

Following on from #15581.

Make Reflection give rules for anonymous actions, making dune rules output more complete.

Additionally, make dune rules default to @default rather than Target.all_direct_targets.

Fixes #11505
Fixes #11564

Checklist

  • Tests added, if applicable.
  • Change log entry added for any user-facing changes.
  • Documentation added for any user-facing changes.

Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
I'm not sure if this is actually necessary; in my testing the action
isn't rerun when multiple of its aliases are built.

Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
This reverts commit 758e8a4.

Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
Signed-off-by: Nat Karmios <nat@karmios.com>
This reverts commit 16eec08.

Signed-off-by: Nat Karmios <nat@karmios.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dune rules should work with all aliases dune rules @runtest is empty in a folder containing a cram test

1 participant