Make short paths lazier #1988
Merged
Make short paths lazier #1988
+79
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
No, it's not clear to me how impactful the performance implications are. The substitutions are often much more expensive in oxcaml due to heavy usage of ppx_template. I also hypothesize (without testing) that this only speeds up Merlin's first typecheck of a buffer - caching may make this (mostly) irrelevant for subsequent requests. Still, I don't think this change can hurt. I've went ahead and updated the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in changes from oxcaml Merlin: oxcaml/merlin#193