feature(lsp): add text document position conversions - #1818
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-uqplxlxnnlln
branch
from
July 28, 2026 06:14
728ef7b to
01d64ef
Compare
Add bidirectional conversion between UTF-8 byte offsets and negotiated LSP positions to String_zipper and Text_document. Property-test offset and range round trips over edits and use the API in source-searching code instead of ad hoc Merlin conversions. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-uqplxlxnnlln
branch
from
July 31, 2026 23:18
01d64ef to
f8c426a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add encoding-aware conversions between LSP positions/ranges and UTF-8 byte offsets without exposing
Text_document's zipper. The existingabsolute_positionandabsolute_rangenames remain as compatibility aliases.Use the new API to remove the byte-offset/lexer-position round trip from the unused-code-action lookup, and cover both directions with UTF-8, UTF-16, and model-based editing tests.
Fixes #1090.