fix(completion): preserve dotted operators - #1890
Merged
Merged
Conversation
rgrinberg
force-pushed
the
push-qpwkxnmtqowx
branch
2 times, most recently
from
July 26, 2026 05:45
a703395 to
2d1868f
Compare
rgrinberg
force-pushed
the
push-uquvzztvtmyp
branch
from
July 26, 2026 05:45
53510ba to
dc5dec7
Compare
rgrinberg
force-pushed
the
push-qpwkxnmtqowx
branch
from
July 26, 2026 09:36
2d1868f to
854ec0b
Compare
rgrinberg
force-pushed
the
push-qpwkxnmtqowx
branch
4 times, most recently
from
July 26, 2026 11:40
61599b8 to
0c6ad9a
Compare
Do not shorten an operator-looking completion prefix as though dots separated a module path. Scan operator suffixes with the operator character set as well, so resolve requests reconstruct dotted operators and return their documentation. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-qpwkxnmtqowx
branch
from
July 31, 2026 22:17
0c6ad9a to
fe00ad7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short completion-prefix reconstruction treats dotted operators like module paths and drops them, while resolve scans only identifier suffixes. Distinguish path-like prefixes from operators and scan operator suffixes so dotted operator completions retain their documentation.