fix(completion): respect negotiated position encoding - #2011
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-yltuqlssvsxl
branch
from
July 30, 2026 22:17
825d84a to
a1ca466
Compare
rgrinberg
force-pushed
the
push-yltuqlssvsxl
branch
3 times, most recently
from
July 31, 2026 22:19
b8b108f to
ced31b6
Compare
Translate completion requests through document offsets and construct edit ranges in the encoding negotiated with the client. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-yltuqlssvsxl
branch
from
July 31, 2026 23:18
ced31b6 to
c1422b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate completion request positions through document offsets before querying Merlin, and construct completion, resolve, and construct-command ranges through document-bound UTF-8 span conversion.
This replaces #1889 with a narrower implementation that keeps negotiated encoding out of completion feature code. Existing Unicode completion and resolve snapshots expose the corrected protocol ranges.