fix(lsp): generate filter and notebook contracts - #2012
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-mzsyvnxyvsrq
branch
from
July 31, 2026 23:18
0f48cdc to
03d6008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates the LSP 3.18 document-filter, relative-pattern, and notebook synchronization contracts instead of retaining stale handwritten placeholders.
This preserves omitted optional filter fields, supports relative patterns with URI or workspace-folder bases, and accepts and emits notebook synchronization objects. Server call sites now construct the generated unions explicitly, and the baseline snapshots from #1996 are updated to show valid wire behavior.