Skip to content

fix(lsp): preserve document URI wire identities - #2023

Open
rgrinberg wants to merge 1 commit into
masterfrom
push-lltplopltrrz
Open

fix(lsp): preserve document URI wire identities#2023
rgrinberg wants to merge 1 commit into
masterfrom
push-lltplopltrrz

Conversation

@rgrinberg

@rgrinberg rgrinberg commented Jul 31, 2026

Copy link
Copy Markdown
Member

Stops URI parsing from changing the URI's spelling. Uri.of_string and JSON decoding now retain the supplied string for serialization, equality, comparison, and hashing, while keeping parsed components for filesystem and query access.

Uri.of_path remains the explicit constructor for producing a canonical file URI. The locate-types request is updated to use it for Merlin filesystem paths.

The URI property tests now generate noncanonical spellings and require exact string and JSON round trips, updating the regression from #2017.

@rgrinberg
rgrinberg force-pushed the push-lltplopltrrz branch 2 times, most recently from 80e7352 to a4caa9c Compare July 31, 2026 22:06
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg
rgrinberg force-pushed the push-lltplopltrrz branch from a4caa9c to 55dfa8a Compare July 31, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant