-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): bump @octokit/app
to fix web users
#2806
Conversation
The `verifyWithFallback()` function was missing from the web code in `@octokit/webhooks-methods`, and was only defined for Node, leaving users unable to use newer versions of `@octokit/webhooks` with this package
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.1 | ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.1 | ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.1 | ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.1 | ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.0 | 4.1.2 | ## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2) ##### Bug Fixes - **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745)) ## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1) ##### Bug Fixes - **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
Resolves #ISSUE_NUMBER
Before the change?
verifyWithFallback()
function was missing from the web code in@octokit/webhooks-methods
, and was only defined for Node, leaving users unable to use newer versions of@octokit/webhooks
with this packageAfter the change?
@octokit/webhooks
to pull in a newer version of@octokit/webhooks-methods
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!