Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @octokit/app to fix web users #2806

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

wolfy1339
Copy link
Member

Resolves #ISSUE_NUMBER


Before the change?

  • The verifyWithFallback() function was missing from the web code in @octokit/webhooks-methods, and was only defined for Node, leaving users unable to use newer versions of @octokit/webhooks with this package

After the change?

  • Bump @octokit/webhooks to pull in a newer version of @octokit/webhooks-methods

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

The `verifyWithFallback()` function was missing from the web code in `@octokit/webhooks-methods`, and was only defined for Node, leaving users unable to use newer versions of `@octokit/webhooks` with this package
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 merged commit 137de2d into main Feb 7, 2025
9 checks passed
@wolfy1339 wolfy1339 deleted the bump-webhooks branch February 7, 2025 00:32
Copy link

github-actions bot commented Feb 7, 2025

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 8, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.1 |


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 9, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.1 |


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 11, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.1 |


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 14, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.1 |


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 15, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 16, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 19, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 21, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 22, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 23, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 26, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 1, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 5, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 8, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 9, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 11, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 13, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 14, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 15, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 16, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 18, 2025
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 4.1.0 | 4.1.2 |


## [v4.1.2](https://github.com/octokit/octokit.js/releases/tag/v4.1.2)

##### Bug Fixes

-   **deps:** update Octokit dependencies to mitigate ReDos vulnerabilities \[security] ([#2816](octokit/octokit.js#2816)) ([28ff745](octokit/octokit.js@28ff745))


## [v4.1.1](https://github.com/octokit/octokit.js/releases/tag/v4.1.1)

##### Bug Fixes

-   **deps:** bump `@octokit/app` to fix web users ([#2806](octokit/octokit.js#2806)) ([137de2d](octokit/octokit.js@137de2d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants