On polymorphic args, suggest pointer when sensible #5818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5817, but independent, as this targets error messages for polymorphic procs, not proc_groups. But the "why" is the same, help new odin users more quickly figure out when they forgot/missed a pass-by-pointer.
When the polymorphic type is explicitly a pointer and our input is not, then we suggest using a pointer.

This might not work if you use indirect types to a pointer, but should cover most cases of new odin user not figuring out why the append_elem, etc calls won't work.
TODO MAYBE:
NOTE:
if(!is_operand_value(operand))case, because pointers to invalid types won't make it more valid, so the if-then-suggestion would never happen there:Addressing_Invalid = 0, // invalid addressing mode
Addressing_NoValue = 1, // no value (void in C)
[...]
Addressing_Type = 6, // type
Addressing_Builtin = 7, // built-in procedure
Addressing_ProcGroup = 8, // procedure group (overloaded procedure)
[...]
}