[FIX] hr_holidays: fix traceback bug when selecting leave type #4898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-haabo, it needs to be retargeted before it can be merged. |
hazemayman1
force-pushed
the
master-hr-onboarding-leave_type_bugfix-haabo
branch
from
4a2a99b to
7899174
Compare
arpi-odoo
requested changes
Dec 3, 2025
arpi-odoo
left a comment
arpi-odoo
left a comment
There was a problem hiding this comment.
The fix is good but you need to change your commit message. For bug fix tasks, we need:
- Steps to reproduce and bug description
- Cause of the bug
- How you fixed it
Also, for bug fixes, we need to add test(s) to prevent the bug from happening again.
Steps to reproduce: - On the Time Off app go to Configuration -> Time Off Types - Select any time off type the click the Time Off smart button - Click new and on the creation form try changing the Time Off type for an employee Cause of the bug: - The function that compares the leave type days and the employee's remaining leave days only gets the leave type days as an input, the other argument is missing Fix done: - Passing the input value as the second argument for the op(v1, v2) function task-5380284
hazemayman1
force-pushed
the
master-hr-onboarding-leave_type_bugfix-haabo
branch
from
7899174 to
32e47ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] hr_holidays: fix traceback bug when selecting leave type
task-5380284