[FIX] hr_holidays: fix leave type operator #4899
Draft
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-joyep, it needs to be retargeted before it can be merged. |
Mahmoudk3m
requested changes
Dec 3, 2025
Mahmoudk3m
left a comment
Mahmoudk3m
left a comment
There was a problem hiding this comment.
Thanks for your work 🚀
The fix is good but I have some comments about the commit message, for bug fixes we need:
- Steps to reproduce and bug description
- Cause of the bug
- How you fixed it
Also, for bug fixes, we need to add tests to prevent it from happening again.
Also, you have a runbot error, make sure to check that out 😉.
Issue: the domain helper did not pass the comparison value to the operator, leading to crashes in allocation-based leave types. Fix: add a return value. Task: 5381490
yewentai
force-pushed
the
master-hr-onboarding-traceback_timeoff_type-joyep
branch
from
192f7ad to
4e9170a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain helper did not pass the comparison value to the operator, leading to crashes in allocation-based leave types.
Task: 5381490