[FIX] composer: Enter/Tab confirm when assistant is force-closed #7382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Comment on lines
391
to
401
| this.assistant.forcedClosed && this.props.composerStore.canBeToggled | ||
| ); | ||
| } | ||
|
|
||
| private processEnterKey(ev: KeyboardEvent, direction: Direction) { | ||
| ev.preventDefault(); | ||
| ev.stopPropagation(); | ||
| if (!this.assistant.forcedClosed) { | ||
| this.props.composerStore.autoCompleteOrStop(direction); | ||
| } | ||
|
|
||
| this.props.composerStore.autoCompleteOrStop( | ||
| direction, | ||
| this.assistant.forcedClosed && this.props.composerStore.canBeToggled |
Collaborator
There was a problem hiding this comment.
would it makes sense to move this part of the condition && this.props.composerStore.canBeToggled in autoCompleteOrStop ?
Contributor
Author
There was a problem hiding this comment.
Yes, it makes sense, centralizing canBeToggled in autoCompleteOrStop keeps the decision in the store.
moved canBeToggled into autoCompleteOrStop.
When the formula assistant was force-closed, Enter/Tab were swallowed and no action occurred. Users could not confirm edits (including plain text). Composer now tells the store when the assistant is force-closed. Enter/Tab confirm the edit if the assistant is open; otherwise, they stop the edition. Task: 5153666
dhrp-odoo
force-pushed
the
saas-18.4-fix-composer-enter-tab-assistant-closed-dhrp
branch
from
d05e4ec to
1fcabef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the formula assistant was force-closed, Enter/Tab were swallowed and no action occurred. Users could not confirm edits (including plain text).
Composer now tells the store when the assistant is force-closed. Enter/Tab confirm the edit if the assistant is open; otherwise, they stop the edition.
Task: 5153666
review checklist